fix: add provenance to release step #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mirko Mollik <[email protected]>
cre8
requested review from
aceshim,
berendsliedrecht,
lukasjhan and
zustkeeper
as code owners
|
@cre8 How about release 0.15.2 to test? It's also good for syncing the version. |
Good idea, but I think for this we need to pass a config parameter to Lerna to force it. I will open a PR for this and then a new release |
|
@jwagantall They are #321 #322 #323. We fixed the links in the package.json |
We needed three PRs since it was not possible to make a dry run to confirm it. But the changes were very small since Lerna already had this feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #318
Adding the flag accoding to: https://docs.npmjs.com/generating-provenance-statements#using-third-party-package-publishing-tools
Can not tested before merge, but should be correct. According to lerna this is already supported in v6, we have v8: lerna/lerna#3657
Signed-off-by: Mirko Mollik [email protected]